]> Frank Brehm's Git Trees - profitbricks/jenkins-build-scripts.git/log
profitbricks/jenkins-build-scripts.git
10 years agoextract_storage: dist of ANDBD must be not dev_feature* but pre-staging
Dongsu Park [Fri, 17 Jan 2014 13:47:17 +0000 (14:47 +0100)]
extract_storage: dist of ANDBD must be not dev_feature* but pre-staging

A yet another bug on building a kernel image from a feature branch.
So far profitbricks-linux-image-storage has been built successfully.
However, its subtask building profitbricks-andbd-modules-storage
has always failed.

Its reason was apt sources list having enabled only dev-repository,
where ANDBD modules are normally not built at all. This could result
in an error case, where installation process of ANDBD module package
tries to find a bogus kernel version, such as 2.6.32.

Even though there would exist any feature branch of ANDBD that matches
exactly with the name of feature branch of linux-storage, we could not
have any way to determine at all, whether the two feature branches
should match with each other. There's no point of using $TARGET_NAME
for configuring distribution of the ANDBD module package.

Therefore the solution is to always add a pre-staging repository
to apt sources list. Then linux-storage from a feature branch can be
installed with andbd-modules from the pre-staging (develop) branch.

(Tested only under my local pbuilder environment)

10 years agoMerge branch 'feature/storage-feature-branch' into develop
Tobias von der Krone [Fri, 17 Jan 2014 09:58:24 +0000 (10:58 +0100)]
Merge branch 'feature/storage-feature-branch' into develop

10 years agoMerge branch 'master' into develop
Benjamin Drung [Wed, 15 Jan 2014 10:05:08 +0000 (11:05 +0100)]
Merge branch 'master' into develop

10 years agoAdd script name to temporary files.
Benjamin Drung [Wed, 15 Jan 2014 10:01:58 +0000 (11:01 +0100)]
Add script name to temporary files.

This allows to track down left-over temporary files to their sources.

10 years agoextract_storage: support for a new format of DISTRIBUTION variable
Dongsu Park [Tue, 14 Jan 2014 12:16:18 +0000 (13:16 +0100)]
extract_storage: support for a new format of DISTRIBUTION variable

since several months, this script has not been able to support for
building feature branch kernels any more. It looks like $DISTRIBUTION
is now being given with a format of "dev_feature_$branchname".

To fix errors of Jenkins job dev-feature_extract-storage-kernel-and
-modules, let's make it support for dev_feature_$branchname" too.

10 years agodebian_build.py: Add --version-suffix parameter.
Benjamin Drung [Thu, 9 Jan 2014 13:54:27 +0000 (14:54 +0100)]
debian_build.py: Add --version-suffix parameter.

10 years agoMerge branch 'master' into develop
Benjamin Drung [Thu, 9 Jan 2014 13:22:43 +0000 (14:22 +0100)]
Merge branch 'master' into develop

10 years agoRename pbuilder environment variable ARCH to ARCHITECTURE.
Benjamin Drung [Thu, 9 Jan 2014 13:18:35 +0000 (14:18 +0100)]
Rename pbuilder environment variable ARCH to ARCHITECTURE.

pbuilder falsely passes all environment variables into the chroot system.
The ARCH enviroment variable causes a build failure in the ethoip6 package.

10 years agoMerge branch 'master' into develop
Benjamin Drung [Fri, 3 Jan 2014 17:36:55 +0000 (18:36 +0100)]
Merge branch 'master' into develop

10 years ago.pbuilderrc: Also consider develop-squeeze as pre-staging distribution.
Benjamin Drung [Fri, 3 Jan 2014 17:36:47 +0000 (18:36 +0100)]
.pbuilderrc: Also consider develop-squeeze as pre-staging distribution.

10 years agoRevert "Only pass --override-config to pbuilder on sqeeze (for now)."
Benjamin Drung [Fri, 3 Jan 2014 17:33:29 +0000 (18:33 +0100)]
Revert "Only pass --override-config to pbuilder on sqeeze (for now)."

This reverts commit 1c1ce75080effe12800dd7d5ea91b39fe4692610.

10 years agoOnly pass --override-config to pbuilder on sqeeze (for now).
Benjamin Drung [Fri, 3 Jan 2014 17:10:46 +0000 (18:10 +0100)]
Only pass --override-config to pbuilder on sqeeze (for now).

10 years agoRemove unused imports and replace * imports.
Benjamin Drung [Mon, 23 Dec 2013 14:50:56 +0000 (15:50 +0100)]
Remove unused imports and replace * imports.

10 years agoCleanup the previous source packages.
Benjamin Drung [Mon, 23 Dec 2013 14:42:50 +0000 (15:42 +0100)]
Cleanup the previous source packages.

10 years agoFix crash when cleaning the repository fails.
Benjamin Drung [Mon, 23 Dec 2013 14:40:40 +0000 (15:40 +0100)]
Fix crash when cleaning the repository fails.

subprocess.check_call will raise an exception instead of returning non-zero.

10 years agoUse --override-config to always have a correct sources.list.
Benjamin Drung [Thu, 12 Dec 2013 18:16:37 +0000 (19:16 +0100)]
Use --override-config to always have a correct sources.list.

10 years agoFollow up commit to make the switch to gitpkg+pbuilder work.
Benjamin Drung [Thu, 12 Dec 2013 17:38:25 +0000 (18:38 +0100)]
Follow up commit to make the switch to gitpkg+pbuilder work.

10 years agoReplace git-buildpackage by gitpkg and pbuilder.
Benjamin Drung [Thu, 12 Dec 2013 16:27:23 +0000 (17:27 +0100)]
Replace git-buildpackage by gitpkg and pbuilder.

This should fix #2744.

10 years agoRevert "lib/git_buildpackage.py: Fix build failure caused by calling clean target."
Benjamin Drung [Thu, 12 Dec 2013 15:44:02 +0000 (16:44 +0100)]
Revert "lib/git_buildpackage.py: Fix build failure caused by calling clean target."

This change was not enough, because pdebuild calls the clean target to a chain.
See http://redmine.pb.local/issues/2744 for details.

This reverts commit 681239fe03ab6f2f4f91f35368199ad9e7dd4880.

10 years agopxe_install.sh: bump FAI time-out to 60 minutes
Thilo Fromm [Wed, 11 Dec 2013 12:51:53 +0000 (13:51 +0100)]
pxe_install.sh: bump FAI time-out to 60 minutes

This bumps the FAI time-out to 60 minutes in order to un-break gateway
auto-deploy.

Signed-off-by: Thilo Fromm <thilo.fromm@profitbricks.com>
10 years agolib/git_buildpackage.py: Fix build failure caused by calling clean target.
Benjamin Drung [Mon, 9 Dec 2013 08:28:52 +0000 (09:28 +0100)]
lib/git_buildpackage.py: Fix build failure caused by calling clean target.

We do want to let dpkg-buildpackage call the clean target, because
it can fail if we do not have all build dependencies installed.
Instead we make sure that the git checkout is clean and the clean
target will be called inside the pbuilder chroot (after the
installation of the build dependencies).

10 years agodebian_build.py: correct build_failed
Tobias von der Krone [Mon, 14 Oct 2013 10:51:20 +0000 (12:51 +0200)]
debian_build.py: correct build_failed

10 years agofail after gathering reports if build has failed
Tobias von der Krone [Mon, 14 Oct 2013 10:36:08 +0000 (12:36 +0200)]
fail after gathering reports if build has failed

11 years agosupport maven3 which changed output...
Holger Levsen [Wed, 25 Sep 2013 16:22:42 +0000 (18:22 +0200)]
support maven3 which changed output...

11 years agochanges taken from sagunt:/root/
Holger Levsen [Wed, 18 Sep 2013 10:21:33 +0000 (12:21 +0200)]
changes taken from sagunt:/root/

11 years agouse riserver for pxe, not jerusalem anymore
Holger Levsen [Fri, 13 Sep 2013 12:20:37 +0000 (14:20 +0200)]
use riserver for pxe, not jerusalem anymore

11 years agoremove traces of testlink, as its not used anymore
Holger Levsen [Fri, 13 Sep 2013 10:18:02 +0000 (12:18 +0200)]
remove traces of testlink, as its not used anymore

11 years agofix build failure after merge to integration branch
Holger Levsen [Wed, 28 Aug 2013 12:02:05 +0000 (14:02 +0200)]
fix build failure after merge to integration branch

11 years agomaven-post-build: dont trigger build if we commit ourself
Holger Levsen [Fri, 23 Aug 2013 11:11:13 +0000 (13:11 +0200)]
maven-post-build: dont trigger build if we commit ourself

11 years agomaven_pre_helper: properly reset master branch. refactor a bit.
Holger Levsen [Fri, 23 Aug 2013 09:54:11 +0000 (11:54 +0200)]
maven_pre_helper: properly reset master branch. refactor a bit.

11 years agoupdate+reset integration branch properly
Holger Levsen [Fri, 23 Aug 2013 09:02:12 +0000 (11:02 +0200)]
update+reset integration branch properly

11 years agoliveboot: delete kernel debug archive when garbage collection ran
Fabian Holler [Thu, 22 Aug 2013 14:37:37 +0000 (16:37 +0200)]
liveboot: delete kernel debug archive when garbage collection ran

delete the liveboot kernel debug archive in /srv/liveboot/debug_archives
when the associated liveboot image is deleted

11 years agoadd script to create liveboot kernel debug archives
Fabian Holler [Thu, 22 Aug 2013 09:34:05 +0000 (11:34 +0200)]
add script to create liveboot kernel debug archives

The script downloads the sources and debug symbols for ethoip6 and the
profitbricks-linux-pserver kernel that are installed on a liveboot.
From the extracted files a tar.xz archive is created that contains
everything what is needed to debug kernel oopses.
The archives is stored at /srv/liveboot/debug_archives on the jenkins
build server

11 years agoMerge branch 'develop'
Holger Levsen [Thu, 22 Aug 2013 16:11:38 +0000 (18:11 +0200)]
Merge branch 'develop'

Conflicts resolved:
debian_build.py

11 years agoextract_storage: fix a bug on selecting modules directory name
Dongsu Park [Thu, 22 Aug 2013 11:43:43 +0000 (13:43 +0200)]
extract_storage: fix a bug on selecting modules directory name

In the sub-script, which is externally invoked by this script,
there was a little bug like "cd /lib/modules/*storage/".
This has been working if there's only 1 directory under /lib/modules.
But after upgrading kernel 3.4.23 to 3.4.51, there could be 2 different
directories, because ANDBD package could be possibly depending on
the older version.

To avoid such situations, set the kernel modules directory just the
same as its kernel version.

11 years agoextract_storage: fix a bug on selecting modules directory name
Dongsu Park [Thu, 22 Aug 2013 11:43:43 +0000 (13:43 +0200)]
extract_storage: fix a bug on selecting modules directory name

In the sub-script, which is externally invoked by this script,
there was a little bug like "cd /lib/modules/*storage/".
This has been working if there's only 1 directory under /lib/modules.
But after upgrading kernel 3.4.23 to 3.4.51, there could be 2 different
directories, because ANDBD package could be possibly depending on
the older version.

To avoid such situations, set the kernel modules directory just the
same as its kernel version.

11 years agostorage_deploy: fix typo in log output
Jack Wang [Wed, 31 Jul 2013 14:57:55 +0000 (16:57 +0200)]
storage_deploy: fix typo in log output

Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
11 years agoMerge remote-tracking branch 'origin/bugfix/reset-integration' into develop
Szymon Bochniak [Tue, 30 Jul 2013 15:49:17 +0000 (17:49 +0200)]
Merge remote-tracking branch 'origin/bugfix/reset-integration' into develop

11 years agoReset local integration branch before merging with the branch to be built
Szymon Bochniak [Tue, 30 Jul 2013 15:04:35 +0000 (17:04 +0200)]
Reset local integration branch before merging with the branch to be built

11 years agoreplace test ([ expression ]) with bash internal [[ expression ]]
Tobias von der Krone [Mon, 29 Jul 2013 07:29:01 +0000 (09:29 +0200)]
replace test ([ expression ]) with bash internal [[ expression ]]

11 years agoretab
Tobias von der Krone [Mon, 29 Jul 2013 07:27:34 +0000 (09:27 +0200)]
retab

11 years agoreplace test ([ expression ]) with bash internal [[ expression ]]
Tobias von der Krone [Mon, 29 Jul 2013 07:25:51 +0000 (09:25 +0200)]
replace test ([ expression ]) with bash internal [[ expression ]]

11 years agocorrect indentations
Tobias von der Krone [Mon, 29 Jul 2013 07:19:12 +0000 (09:19 +0200)]
correct indentations

11 years agoMerge branch 'develop' of git+ssh://git/srv/git/so/jenkins_build_script into develop
Tobias von der Krone [Mon, 29 Jul 2013 06:48:07 +0000 (08:48 +0200)]
Merge branch 'develop' of git+ssh://git/srv/git/so/jenkins_build_script into develop

11 years agowe love typos
Holger Levsen [Fri, 26 Jul 2013 16:05:36 +0000 (18:05 +0200)]
we love typos

11 years agoadd export to ease debugging
Holger Levsen [Fri, 26 Jul 2013 16:04:36 +0000 (18:04 +0200)]
add export to ease debugging

11 years agoexplicitly checkout that branch
Holger Levsen [Fri, 26 Jul 2013 16:03:02 +0000 (18:03 +0200)]
explicitly checkout that branch

11 years agoobey no-test build trigger and add figlet output
Holger Levsen [Fri, 26 Jul 2013 15:41:31 +0000 (17:41 +0200)]
obey no-test build trigger and add figlet output

11 years agoalso pull in changes from origin
Holger Levsen [Fri, 26 Jul 2013 14:51:47 +0000 (16:51 +0200)]
also pull in changes from origin

11 years agoadd support for bugfix branches
Holger Levsen [Fri, 26 Jul 2013 13:54:10 +0000 (15:54 +0200)]
add support for bugfix branches

11 years agoprocess incoming after upload
Holger Levsen [Fri, 26 Jul 2013 11:15:36 +0000 (13:15 +0200)]
process incoming after upload

11 years agofix DISTRIBUTION replacement
Holger Levsen [Fri, 26 Jul 2013 10:59:06 +0000 (12:59 +0200)]
fix DISTRIBUTION replacement

11 years agobe more verbose
Holger Levsen [Thu, 25 Jul 2013 17:09:13 +0000 (19:09 +0200)]
be more verbose

11 years agocorrectly add new changelog entry
Holger Levsen [Thu, 25 Jul 2013 17:07:58 +0000 (19:07 +0200)]
correctly add new changelog entry

11 years agomore debugging
Holger Levsen [Thu, 25 Jul 2013 16:02:58 +0000 (18:02 +0200)]
more debugging

11 years agobe even more verbose
Holger Levsen [Thu, 25 Jul 2013 15:30:30 +0000 (17:30 +0200)]
be even more verbose

11 years agobe more verbose for debugging
Holger Levsen [Thu, 25 Jul 2013 15:18:40 +0000 (17:18 +0200)]
be more verbose for debugging

11 years agorefactoring
Holger Levsen [Thu, 25 Jul 2013 15:04:41 +0000 (17:04 +0200)]
refactoring

11 years agoadd check for valid SUITE and let it default to squeeze
Holger Levsen [Thu, 25 Jul 2013 14:41:02 +0000 (16:41 +0200)]
add check for valid SUITE and let it default to squeeze

11 years agofixup: derive suite from jenkins job. cleanup + restructure code
Holger Levsen [Thu, 25 Jul 2013 14:18:09 +0000 (16:18 +0200)]
fixup: derive suite from jenkins job. cleanup + restructure code

11 years agoderive suite from jenkins job. cleanup + restructure code
Holger Levsen [Thu, 25 Jul 2013 13:57:00 +0000 (15:57 +0200)]
derive suite from jenkins job. cleanup + restructure code

11 years agoimprove output
Holger Levsen [Thu, 25 Jul 2013 13:05:15 +0000 (15:05 +0200)]
improve output

11 years agoless cleaning is enough
Holger Levsen [Thu, 25 Jul 2013 12:49:28 +0000 (14:49 +0200)]
less cleaning is enough

11 years agofix upload, add cleanup after upload, add some more comments
Holger Levsen [Thu, 25 Jul 2013 12:41:25 +0000 (14:41 +0200)]
fix upload, add cleanup after upload, add some more comments

11 years agoimplement uploading, add comments
Holger Levsen [Thu, 25 Jul 2013 11:23:27 +0000 (13:23 +0200)]
implement uploading, add comments

11 years agocleanup maven repo before build. set BUILD_NUMBER in version correctly
Holger Levsen [Wed, 24 Jul 2013 16:59:39 +0000 (18:59 +0200)]
cleanup maven repo before build. set BUILD_NUMBER in version correctly

11 years agopush back intregation branch if merge+build was successful
Holger Levsen [Wed, 24 Jul 2013 16:46:17 +0000 (18:46 +0200)]
push back intregation branch if merge+build was successful

11 years agocorrectly detect merge triggers
Holger Levsen [Wed, 24 Jul 2013 16:22:57 +0000 (18:22 +0200)]
correctly detect merge triggers

11 years agorename script and add a pre-build script, to merge feature branches into integration
Holger Levsen [Wed, 24 Jul 2013 16:00:52 +0000 (18:00 +0200)]
rename script and add a pre-build script, to merge feature branches into integration

11 years agofixup: create debian/changelog correctly, handle master branch differently. create...
Holger Levsen [Wed, 24 Jul 2013 15:45:31 +0000 (17:45 +0200)]
fixup: create debian/changelog correctly, handle master branch differently. create proper debianized version of SNAPSHOTs

11 years agofixup: create debian/changelog correctly, handle master branch differently. create...
Holger Levsen [Wed, 24 Jul 2013 15:34:02 +0000 (17:34 +0200)]
fixup: create debian/changelog correctly, handle master branch differently. create proper debianized version of SNAPSHOTs

11 years agocreate debian/changelog correctly, handle master branch differently. create proper...
Holger Levsen [Wed, 24 Jul 2013 15:27:00 +0000 (17:27 +0200)]
create debian/changelog correctly, handle master branch differently. create proper debianized version of SNAPSHOTs

11 years agocreate proper changelog entry
Holger Levsen [Wed, 24 Jul 2013 14:43:14 +0000 (16:43 +0200)]
create proper changelog entry

11 years agoadd tag to successful master builds
Holger Levsen [Wed, 24 Jul 2013 12:27:56 +0000 (14:27 +0200)]
add tag to successful master builds

11 years agocommit debian/changelog if applicable and set correct distro for feature branches
Holger Levsen [Wed, 24 Jul 2013 12:21:21 +0000 (14:21 +0200)]
commit debian/changelog if applicable and set correct distro for feature branches

11 years agoadd check for valid distros and git_branches
Holger Levsen [Wed, 24 Jul 2013 11:50:39 +0000 (13:50 +0200)]
add check for valid distros and git_branches

11 years agodebian_wrap_maven_results.sh: write proper changelog
Holger Levsen [Tue, 23 Jul 2013 17:02:38 +0000 (19:02 +0200)]
debian_wrap_maven_results.sh: write proper changelog

11 years agoMerge branch 'develop' of git+ssh://git/srv/git/so/jenkins_build_script into develop
Tobias von der Krone [Tue, 23 Jul 2013 14:43:56 +0000 (16:43 +0200)]
Merge branch 'develop' of git+ssh://git/srv/git/so/jenkins_build_script into develop

11 years agodebian_wrap_maven_results.sh: calculate version using maven. only require one param...
Holger Levsen [Tue, 23 Jul 2013 13:13:55 +0000 (15:13 +0200)]
debian_wrap_maven_results.sh: calculate version using maven. only require one param, not three

11 years agoadd debian_wrap_maven_results.sh as taken from Szymon from vdc-bundles.git, branch...
Holger Levsen [Tue, 23 Jul 2013 13:05:24 +0000 (15:05 +0200)]
add debian_wrap_maven_results.sh as taken from Szymon from vdc-bundles.git, branch feature/debian

11 years agoAdded script to lock the testsystem.
Marjan Schiller [Mon, 15 Jul 2013 14:16:41 +0000 (16:16 +0200)]
Added script to lock the testsystem.

11 years agoMerge branch 'feature/redmine507' into develop
Tobias von der Krone [Fri, 5 Jul 2013 09:18:44 +0000 (11:18 +0200)]
Merge branch 'feature/redmine507' into develop

11 years agoAdded switch for updating test state.
Marjan Schiller [Thu, 4 Jul 2013 08:12:44 +0000 (10:12 +0200)]
Added switch for updating test state.

11 years ago#507: make failed build not failing the jenkins job
Tobias von der Krone [Thu, 4 Jul 2013 07:43:24 +0000 (09:43 +0200)]
#507: make failed build not failing the jenkins job

11 years agoDEVINF-383: add correct version number (with epoch) to cidb
root sagunt [Mon, 1 Jul 2013 08:09:16 +0000 (08:09 +0000)]
DEVINF-383: add correct version number (with epoch) to cidb

11 years agoDEVINF-383: add correct version number (with epoch) to cidb
root sagunt [Mon, 1 Jul 2013 08:08:46 +0000 (08:08 +0000)]
DEVINF-383: add correct version number (with epoch) to cidb

11 years agoMerge branch 'develop' of ssh://git/srv/git/so/jenkins_build_script into develop
Mathias Klette [Fri, 28 Jun 2013 09:24:13 +0000 (11:24 +0200)]
Merge branch 'develop' of ssh://git/srv/git/so/jenkins_build_script into develop

11 years agodebian_build: DEVINF-383: epoch must be kept but needs quoting
Mathias Klette [Fri, 28 Jun 2013 09:23:27 +0000 (11:23 +0200)]
debian_build: DEVINF-383: epoch must be kept but needs quoting

11 years agoAdded more infos for the autotest result mail.
Marjan Schiller [Thu, 27 Jun 2013 14:34:10 +0000 (16:34 +0200)]
Added more infos for the autotest result mail.

11 years agodebian_build: reset new_version upon auto-increment packages
Mathias Klette [Wed, 26 Jun 2013 10:47:35 +0000 (12:47 +0200)]
debian_build: reset new_version upon auto-increment packages

11 years agodebian_buid.py: reset new_tag when build with autoincrement
Mathias Klette [Mon, 24 Jun 2013 11:42:33 +0000 (13:42 +0200)]
debian_buid.py: reset new_tag when build with autoincrement

let's assume this:
- user changes files but not version in changelog and commits
- call_jenkins accepts and triggers build
- debian_build.py figures out version / tag to create from changelog
- debian_build.py will incrase version number and pushes new HEAD back to origin
- call_jenkins will not push trigger another jenkins call
- debian_build.py will build with the new version
- tagging must happen when build was successful BUT with the new version number
  instead of the one gathered in the very first beginning of the script

11 years agodebian_build: show more details of your tag checks
Mathias Klette [Fri, 21 Jun 2013 15:32:48 +0000 (17:32 +0200)]
debian_build: show more details of your tag checks

11 years agodebian_build: issue warning in manual build instructions
Mathias Klette [Fri, 21 Jun 2013 14:04:52 +0000 (16:04 +0200)]
debian_build: issue warning in manual build instructions

11 years agomove GIT_BRANCH_NAME definitions from common_code to debian_build (again)
Mathias Klette [Fri, 21 Jun 2013 11:33:31 +0000 (13:33 +0200)]
move GIT_BRANCH_NAME definitions from common_code to debian_build (again)

11 years agoadd pbuilder and git-buildpackage configuration, incl. hooks to git
Mathias Klette [Fri, 21 Jun 2013 10:00:27 +0000 (12:00 +0200)]
add pbuilder and git-buildpackage configuration, incl. hooks to git

11 years agoadd pbuilder and git-buildpackage configuration, incl. hooks to git
Mathias Klette [Fri, 21 Jun 2013 10:00:27 +0000 (12:00 +0200)]
add pbuilder and git-buildpackage configuration, incl. hooks to git

11 years agodebian_build: show environment, that gbp object creates, add FIXME
Mathias Klette [Thu, 20 Jun 2013 15:56:46 +0000 (17:56 +0200)]
debian_build: show environment, that gbp object creates, add FIXME

11 years agodebian_build: wheezy based git lib does not allow to use undefined attributes
Mathias Klette [Thu, 20 Jun 2013 13:03:14 +0000 (15:03 +0200)]
debian_build: wheezy based git lib does not allow to use undefined attributes

11 years agoMerge branch 'feature/multipledists' into develop
Mathias Klette [Wed, 19 Jun 2013 12:04:07 +0000 (14:04 +0200)]
Merge branch 'feature/multipledists' into develop

11 years agodebian_build: ensure instructions are shown no matter if build was successful
Mathias Klette [Mon, 17 Jun 2013 10:53:50 +0000 (12:53 +0200)]
debian_build: ensure instructions are shown no matter if build was successful